(docker) enable cross platform build using docker buildx (\#9073)#9074
Merged
cmwaters merged 2 commits intotendermint:mainfrom Aug 4, 2022
Merged
Conversation
c5b2ba5 to
4f61c6b
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
|
Hey @highercomve, do you mind basing this against |
4f61c6b to
bccee81
Compare
Contributor
Author
Hello @cmwaters i changed the base to |
bccee81 to
cf1eccd
Compare
cmwaters
approved these changes
Aug 4, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 9, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 12, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9073
Enable the possibility to receive the parameter TARGETPLATFORM from docker inside the Makefile (when is using buildx or DOCKER_BUILDKIT=1) to decide the correct GOARCH, GOOS and GOARM version.
With this change we can now cross build tendermint inside a container using the
--platformparameter.