Work around indexing problem for duplicate transactions (forward port: #8625)#8945
Merged
tychoish merged 2 commits intotendermint:masterfrom Jul 6, 2022
Merged
Conversation
…tendermint#8625) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess jesse@soob.co ref: tendermint#5281
yihuang
commented
Jul 6, 2022
| - [cli] \#8276 scmigrate: ensure target key is correctly renamed. (@creachadair) | ||
| - [cli] \#8294 keymigrate: ensure block hash keys are correctly translated. (@creachadair) | ||
| - [cli] \#8352 keymigrate: ensure transaction hash keys are correctly translated. (@creachadair) | ||
| - (indexer) \#8625 Fix overriding tx index of duplicated txs. |
Author
There was a problem hiding this comment.
Suggested change
| - (indexer) \#8625 Fix overriding tx index of duplicated txs. | |
| - (indexer) \#8945 Fix overriding tx index of duplicated txs. |
creachadair
approved these changes
Jul 6, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
…#8625) (#8945) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess jesse@soob.co ref: #5281 Co-authored-by: M. J. Fromberger <fromberger@interchain.io> (cherry picked from commit be6d74e) # Conflicts: # CHANGELOG_PENDING.md # internal/state/indexer/indexer_service.go
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
…#8625) (#8945) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess jesse@soob.co ref: #5281 Co-authored-by: M. J. Fromberger <fromberger@interchain.io> (cherry picked from commit be6d74e)
tychoish
pushed a commit
that referenced
this pull request
Jul 6, 2022
…#8625) (#8945) (#8951) Port the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work. fix: prevent duplicate tx index if it succeeded before fix: use CodeTypeOk instead of 0 fix: handle duplicate txs within the same block Co-authored-by: jess jesse@soob.co ref: #5281 Co-authored-by: M. J. Fromberger <fromberger@interchain.io> (cherry picked from commit be6d74e) Co-authored-by: yihuang <huang@crypto.com>
5 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port: #8625
Port and refactored the bug fix terra-money#76 to upstream. This is critical for ethermint json-rpc to work.
Co-authored-by: jess jesse@soob.co
ref: #5281
Please add a description of the changes that this PR introduces and the files that
are the most critical to review.
If this PR fixes an open Issue, please include "Closes #XXX" (where "XXX" is the Issue number)
so that GitHub will automatically close the Issue when this PR is merged.