rpc: enable the ADR 075 event log by default in new configs#8572
Merged
creachadair merged 1 commit intomasterfrom May 17, 2022
Merged
rpc: enable the ADR 075 event log by default in new configs#8572creachadair merged 1 commit intomasterfrom
creachadair merged 1 commit intomasterfrom
Conversation
Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
tychoish
approved these changes
May 17, 2022
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
…nt#8572) Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
…nt#8572) Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
…nt#8572) Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
…nt#8572) Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 8, 2022
…nt#8572) Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
3 tasks
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 8, 2022
…nt#8572) Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 8, 2022
…nt#8572) Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
thanethomson
pushed a commit
that referenced
this pull request
Dec 8, 2022
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are deprecating the stream-based event subscription in v0.36, we should ensure that new nodes enable the replacement by default. For now, just set a baseline 30-second window.
We already have a changelog entry for the ADR 075 interface, that should be sufficient to cover this as well.