rpc: implement the ADR 075 /events method#7965
Merged
creachadair merged 3 commits intomasterfrom Feb 23, 2022
Merged
Conversation
50d2663 to
03192a8
Compare
This was referenced Feb 22, 2022
c84cfa3 to
9ba6ec9
Compare
tychoish
reviewed
Feb 22, 2022
7b79f8f to
bb3200a
Compare
tychoish
approved these changes
Feb 23, 2022
| // and we want to keep waiting until we have relevant results (or time out). | ||
| cur := after | ||
| for len(items) == 0 { | ||
| info, err = env.EventLog.WaitScan(ctx, cur, accept) |
Contributor
There was a problem hiding this comment.
Q about this implementation: does WaitScan allow the full ctx to elapse or does it scan the list as soon as items are available? A client may have listed that they are willing to wait a long time for items and want a lot of items. If such a client arrives at an empty list that then has 1 item appended followed by a ton of items, I think they will just get the 1 item back, which feels a little off since they are still willing to wait for the entire waitTime for their items.
Author
There was a problem hiding this comment.
It returns as soon as it has something. That's how it's defined in the ADR but it wouldn't be hard to change it to keep trying.
I think we probably want to return eagerly though:
A client who's waiting has already found no matches, so they're right at the head of the log. Do they want to wait for more items or have the new data ASAP? We can't know, but if they want "more" they can easily call again (and probably reuse the same HTTP connection).
By contrast if they DIDN'T want to wait, they have to kinda tune their timeout carefully and will wind up polling rapidly just to avoid stalling.
So my intuition is that eager is better, but it isn't much work to change it if there's a good case for waiting.
added 3 commits
February 23, 2022 14:54
This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this.
- Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination
b20ede2 to
006dc60
Compare
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 29, 2022
This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Sep 28, 2022
This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination
3 tasks
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Sep 28, 2022
This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination
sergio-mena
pushed a commit
that referenced
this pull request
Oct 4, 2022
* rpc: implement the ADR 075 /events method (#7965) This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination * add MatchesEvents test * add TODO due to backport sequence Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…dermint#9497) * rpc: implement the ADR 075 /events method (tendermint#7965) This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination * add MatchesEvents test * add TODO due to backport sequence Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
…dermint#9497) * rpc: implement the ADR 075 /events method (tendermint#7965) This method implements the eventlog extension interface to expose ABCI metadata to the log for query processing. Only the types that have ABCI events need to implement this. - Add an event log to the environment - Add a sketch of the handler method - Add an /events RPCFunc to the route map - Implement query logic - Subscribe to pubsub if confingured, handle termination * add MatchesEvents test * add TODO due to backport sequence Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the new method on the RPC environment, and adds data types for the parameters and results of that method.
It also updates the event data types that have ABCI events to expose them to the event log.