Conversation
| @@ -1204,6 +1204,10 @@ func (cs *ConsensusState) finalizeCommit(height int) { | |||
| err := stateCopy.ApplyBlock(eventCache, cs.proxyAppConn, block, blockParts.Header(), cs.mempool) | |||
| if err != nil { | |||
| cs.Logger.Error("Error on ApplyBlock. Did the application crash? Please restart tendermint", "err", err) | |||
There was a problem hiding this comment.
Perhaps we should remove this error message then and instead make it
if err != nil {
if err := cmn.Kill(); err != nil {
// Maybe log that we successfully killed Tendermint
} else {
cs.Logger.Error("Error on ApplyBlock. Did the application crash? Please restart Tendermint manually", "err", err)
}
return
}There was a problem hiding this comment.
I think we need to alert the user when the app crashes, and then initiate tear down. If tear down fails, we should log that error too.
There was a problem hiding this comment.
Alright, at least let's change the message asking them to start Tendermint yet we are doing it right after logging the message
There was a problem hiding this comment.
What do you mean? We tell the user to restart tendermint, and then we go and kill it. So then they, or their OS, can restart it!
There was a problem hiding this comment.
Oops I was definitely mistaken. For some reason when I read the commit message Tendermint should die if app hash does so OS can handle restarts I assumed that Tendermint would be auto-restarted or the OS would handle it exiting, but I re-read everything after your comment. My apologies.
8d70f39 to
fe1c60b
Compare
…nt#794) * Unsafe int cast in `kill` command (tendermint#783) * Unsafe int cast in `kill` command * Revert "Unsafe int cast in `kill` command" This reverts commit bbd649bd372ca90f83dea7b424d67dafbd9eb541. * Changed strategy (cherry picked from commit 03c5e77) # Conflicts: # cmd/cometbft/commands/debug/kill.go * Revert "Unsafe int cast in `kill` command (tendermint#783)" This reverts commit b7ab279a6df1f062bec60bcf95947d2a87f4ccec. * Unsafe int cast in `kill` command (tendermint#783) * Unsafe int cast in `kill` command * Revert "Unsafe int cast in `kill` command" This reverts commit bbd649bd372ca90f83dea7b424d67dafbd9eb541. * Changed strategy --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
#243 (comment)
Tendermint should die if app hash does so OS can handle restarts