Skip to content

Remove master from the docs site version config.#7874

Merged
creachadair merged 1 commit intomasterfrom
mjf/no-master-docs
Feb 21, 2022
Merged

Remove master from the docs site version config.#7874
creachadair merged 1 commit intomasterfrom
mjf/no-master-docs

Conversation

@creachadair
Copy link

@creachadair creachadair commented Feb 18, 2022 •
edited
Loading

We might want to do this for v0.33 also.

Per the below we'll keep v0.33 for now.

@creachadair creachadair force-pushed the mjf/no-master-docs branch 2 times, most recently from b22e8a5 to cbcb04b Compare February 18, 2022 18:26
@creachadair
Copy link
Author

creachadair commented Feb 18, 2022

Going to hold this till after #7870 and #7871 so that we get the link updates in the versions as well.

@creachadair creachadair force-pushed the mjf/no-master-docs branch 7 times, most recently from 1b35816 to db7427e Compare February 19, 2022 21:10
@creachadair creachadair mentioned this pull request Feb 19, 2022
Closed
5 tasks
@creachadair creachadair force-pushed the mjf/no-master-docs branch 2 times, most recently from fc7fbca to 9f6150e Compare February 20, 2022 19:37
cmwaters
cmwaters approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep v0.33 for now. I think we should keep docs around for 1 or 2 more versions than what we promise to actively maintain.

@cmwaters
Copy link
Contributor

cmwaters commented Feb 21, 2022

The interesting thing is that we need to remove master on all the backported branches as well :)

@cmwaters cmwaters added S:backport-to-v0.34.x Tell mergify to backport the PR to v0.34.x S:backport-to-v0.35.x labels Feb 21, 2022
@creachadair
Copy link
Author

creachadair commented Feb 21, 2022

The interesting thing is that we need to remove master on all the backported branches as well :)

Yup. To v0.33 also, but that one will have to be manual as it predates our automation. 🙂

@cmwaters
Copy link
Contributor

cmwaters commented Feb 21, 2022

I've also noticed that the backported branches still reference v0.32 as well

@creachadair
Copy link
Author

creachadair commented Feb 21, 2022

I've also noticed that the backported branches still reference v0.32 as well

Yeah, I'll do a cleanup pass on all of them.

@creachadair creachadair merged commit 351adf8 into master Feb 21, 2022
@creachadair creachadair deleted the mjf/no-master-docs branch February 21, 2022 14:07
mergify bot pushed a commit that referenced this pull request Feb 21, 2022
Remove master from the docs site version config. (#7874)
ad0d9b4 
(cherry picked from commit 351adf8)

# Conflicts:
#	docs/.vuepress/config.js
#	docs/versions
@mergify mergify bot mentioned this pull request Feb 21, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 21, 2022
Remove master from the docs site version config. (#7874)
b054edd 
(cherry picked from commit 351adf8)

# Conflicts:
#	docs/versions
@mergify mergify bot mentioned this pull request Feb 21, 2022
Merged
creachadair pushed a commit that referenced this pull request Feb 21, 2022
@mergify
Remove master from the docs site version config. (backport #7874) (#7903
8c24914 
)

* Remove master from the docs site version config. (#7874)

(cherry picked from commit 351adf8)

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
creachadair pushed a commit that referenced this pull request Feb 21, 2022
@mergify
Remove master from the docs site version config. (backport #7874) (#7902
de42367 
)

* Remove master from the docs site version config. (#7874)

(cherry picked from commit 351adf8)

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
creachadair pushed a commit that referenced this pull request Feb 21, 2022
(backport) Remove master from the docs site version config. (#7874)
7b21910 
A manual cherry-pick of 351adf8.
creachadair pushed a commit that referenced this pull request Feb 21, 2022
(backport) Remove master from the docs site version config. (#7874) (#…
9140860 
…7905)

A manual cherry-pick of 351adf8.
@creachadair
Copy link
Author

creachadair commented Feb 22, 2022

It appears a lot of the search results on Google point directly to master for whatever reason. I think we ought to probably set up a redirect from master to the latest release (v0.35) on the generated site, so that those links at least go somewhere relevant instead of 404.

@cmwaters cmwaters mentioned this pull request Feb 22, 2022
Merged
lklimek referenced this pull request in dashpay/tenderdash Apr 1, 2022
@mergify @lklimek
Remove master from the docs site version config. (backport #7874) (#7…
48cf18d 
…903)

* Remove master from the docs site version config. (#7874)

(cherry picked from commit 351adf8)

Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
(cherry picked from commit 8c24914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

3 more reviewers

@tychoish tychoish tychoish approved these changes

@williambanfield williambanfield williambanfield approved these changes

@cmwaters cmwaters cmwaters approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S:backport-to-v0.34.x Tell mergify to backport the PR to v0.34.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@creachadair @cmwaters @tychoish @williambanfield