Skip to content

Use proposer timestamp instead of genesis time for height 1 block time#7541

Merged
williambanfield merged 37 commits intowb/proposer-based-timestampsfrom
anca/pbts_tests_offset
Jan 27, 2022
Merged

Use proposer timestamp instead of genesis time for height 1 block time#7541
williambanfield merged 37 commits intowb/proposer-based-timestampsfrom
anca/pbts_tests_offset

Conversation

@ancazamfir
Copy link
Contributor

@ancazamfir ancazamfir commented Jan 10, 2022

Closes: #7546
In addition to the changes for #7546, experimenting with using duration offsets to eliminate non-determinism from pbts tests. Since height 1 doesn't use the genesis time anymore it is hard to get the other timestamps correct.
Just trying to specify the heights > 1 timestamps in offsets relative to height 1

ancazamfir and others added 30 commits December 9, 2021 08:25
@ancazamfir ancazamfir force-pushed the anca/prevote_nil_untimely branch from a6e5a89 to 693bae7 Compare January 11, 2022 08:57
@ancazamfir ancazamfir changed the title try to use time offsets in pbts tests Use proposer timestamp instead of genesis time for heigh 1 block time Jan 11, 2022
Base automatically changed from anca/prevote_nil_untimely to wb/proposer-based-timestamps January 11, 2022 10:44
@creachadair creachadair changed the title Use proposer timestamp instead of genesis time for heigh 1 block time Use proposer timestamp instead of genesis time for height 1 block time Jan 11, 2022
@williambanfield
Copy link
Contributor

The general change looks great, just some fixups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants