Use proposer timestamp instead of genesis time for height 1 block time#7541
Merged
williambanfield merged 37 commits intowb/proposer-based-timestampsfrom Jan 27, 2022
Merged
Conversation
a6e5a89 to
693bae7
Compare
Base automatically changed from
anca/prevote_nil_untimely
to
wb/proposer-based-timestamps
January 11, 2022 10:44
Contributor
|
The general change looks great, just some fixups. |
williambanfield
pushed a commit
that referenced
this pull request
Jan 27, 2022
30 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #7546
In addition to the changes for #7546, experimenting with using duration offsets to eliminate non-determinism from pbts tests. Since height
1doesn't use the genesis time anymore it is hard to get the other timestamps correct.Just trying to specify the heights > 1 timestamps in offsets relative to height 1