consensus: check that proposal is non-nil before voting#7480
Merged
williambanfield merged 2 commits intowb/proposer-based-timestampsfrom Dec 22, 2021
Merged
consensus: check that proposal is non-nil before voting#7480williambanfield merged 2 commits intowb/proposer-based-timestampsfrom
williambanfield merged 2 commits intowb/proposer-based-timestampsfrom
Conversation
ancazamfir
approved these changes
Dec 20, 2021
Contributor
ancazamfir
left a comment
There was a problem hiding this comment.
lgtm, thanks for finding the issue and the fix @williambanfield!
williambanfield
added a commit
that referenced
this pull request
Jan 15, 2022
1 task
4 tasks
adizere
pushed a commit
to cometbft/cometbft
that referenced
this pull request
Feb 7, 2024
…2221) Addresses #2119. ADR 112, describing the PBTS implementation, [states](https://github.com/cometbft/cometbft/pull/2223/files#diff-81d55f6e52eabd6cce264a76fba015de46092b9ccda241de10cd265890ab8ad9R302): The precommit step will not require much modification. Its proposal validation rules will change in the same ways that validation will change in the prevote step with the exception of the `timely` check: precommit validation will never check that the timestamp is `timely`. The changes proposed here are in line with this description. Moreover, this PR in fact revert the changes to the precommit step (`enterPrecommit` method) added by tendermint/tendermint#7480 and tendermint/tendermint#7391. --- #### PR checklist - [x] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response to debugging with @ancazamfir. Proposal can be nil if not sent.