Skip to content

701 add dev docs in java#746

Merged
zramsay merged 4 commits intotendermint:docs-stagingfrom
srmo:701-add-dev-docs-in-java
Oct 15, 2017
Merged

701 add dev docs in java#746
zramsay merged 4 commits intotendermint:docs-stagingfrom
srmo:701-add-dev-docs-in-java

Conversation

@srmo
Copy link
Contributor

@srmo srmo commented Oct 15, 2017

[docs] added new code to allow creation of collapsible code blocks
[docs] added a java example for each go example in app development section

@srmo srmo requested a review from ebuchman as a code owner October 15, 2017 11:47
@codecov-io
Copy link

codecov-io commented Oct 15, 2017

Codecov Report

Merging #746 into develop will decrease coverage by 0.64%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #746      +/-   ##
===========================================
- Coverage    57.85%   57.21%   -0.65%     
===========================================
  Files           82       82              
  Lines         8436     8436              
===========================================
- Hits          4881     4827      -54     
- Misses        3142     3186      +44     
- Partials       413      423      +10

@zramsay
Copy link
Contributor

zramsay commented Oct 15, 2017

Amazing! Have tested it locally & it works great. I'll probably merge this into a docs-staging branch and trigger those builds on read the docs for others to easily see.

@srmo
Copy link
Contributor Author

srmo commented Oct 15, 2017

@zramsay One thing to mention is that this requires ES6 support in the browser, so it might not work with older browsers.

@zramsay zramsay changed the base branch from develop to docs-staging October 15, 2017 14:59
@zramsay zramsay requested a review from nylira October 15, 2017 15:01
@zramsay
Copy link
Contributor

zramsay commented Oct 15, 2017

merging to docs-staging, @nylira can you review the js code here?

@zramsay zramsay merged commit 4c1f1e4 into tendermint:docs-staging Oct 15, 2017
@zramsay zramsay mentioned this pull request Oct 15, 2017
@srmo srmo deleted the 701-add-dev-docs-in-java branch October 15, 2017 18:22
cmwaters pushed a commit to cmwaters/tendermint that referenced this pull request Dec 12, 2022
…endermint#746)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 2.5.1 to 3.2.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v2.5.1...v3.2.0)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this pull request Nov 24, 2023
* Rephrase log when committed TX not in local mempool + make it debug

* Add failing UT

* Fill time in ExecCommitBlock

* Fix UT logic

* Revert unrelated commit "Rephrase log when committed TX not in local mempool + make it debug"

* Fix lint

(cherry picked from commit b8187b0)

Co-authored-by: Sergio Mena <sergio@informal.systems>
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this pull request Feb 1, 2024
* Rephrase log when committed TX not in local mempool + make it debug

* Add failing UT

* Fill time in ExecCommitBlock

* Fix UT logic

* Revert unrelated commit "Rephrase log when committed TX not in local mempool + make it debug"

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants