Remove MedianTime, set block time to Now()#7382
Merged
ancazamfir merged 3 commits intowb/proposer-based-timestampsfrom Dec 9, 2021
Merged
Remove MedianTime, set block time to Now()#7382ancazamfir merged 3 commits intowb/proposer-based-timestampsfrom
ancazamfir merged 3 commits intowb/proposer-based-timestampsfrom
Conversation
Contributor
|
Other than the failing lint, this looks completely correct. |
williambanfield
suggested changes
Dec 7, 2021
internal/state/validation_test.go
Outdated
| "time" | ||
|
|
||
| "github.com/tendermint/tendermint/crypto/ed25519" | ||
| "github.com/tendermint/tendermint/crypto/tmhash" |
Contributor
There was a problem hiding this comment.
nit: order these below with the rest of the tendermint library imports.
Contributor
There was a problem hiding this comment.
having go imports setup in your editor should take care of this sort of thing.
Contributor
There was a problem hiding this comment.
It looks like this happens if you run goimports on a file where the import ordering was previously incorrect. It doesn't realize which block it should put the incorrectly ordered libraries into so it just puts them into a new block but generally it definitely should be the way to avoid this.
williambanfield
approved these changes
Dec 8, 2021
cmwaters
approved these changes
Dec 8, 2021
williambanfield
pushed a commit
that referenced
this pull request
Jan 15, 2022
* Remove MedianTime, set block time to Now() * Fix goimports * Fix import ordering
30 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
Remove all the median time checks.from #6942