consensus: refactor the fake validator to take a clock source#7300
Merged
williambanfield merged 6 commits intowb/proposer-based-timestampsfrom Nov 22, 2021
Merged
Conversation
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
williambanfield
added a commit
that referenced
this pull request
Nov 24, 2021
williambanfield
added a commit
that referenced
this pull request
Jan 15, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mild refactor of the state tests. This refactor performs two things:
The
validatorStubobjects now are created with a clock source that they use when signing votes. The goal of this is to be able to control the timestamps that votes are signed with for future testing with proposer based timestamps.The vote signing helper functions have been altered slightly. They now take a
types.BlockIDinstead of the constituent pieces of aBlockIDthis seems a bit cleaner and aids readability. They also no longer take aConfigobject and instead take the one piece of configuration information that they need, theChainID. This helps the test harness I'm working on by making it not need to keep track of so many disparate pieces of state.