light: add case to catch cancelled contexts within the detector#6701
Merged
light: add case to catch cancelled contexts within the detector#6701
Conversation
alexanderbez
suggested changes
Jul 13, 2021
tychoish
approved these changes
Jul 13, 2021
alexanderbez
approved these changes
Jul 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #6701 +/- ##
==========================================
+ Coverage 60.83% 60.90% +0.07%
==========================================
Files 297 297
Lines 28227 28229 +2
==========================================
+ Hits 17172 17194 +22
+ Misses 9319 9304 -15
+ Partials 1736 1731 -5
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
(cherry picked from commit 40fba39) # Conflicts: # light/detector.go # light/provider/mock/mock.go
cmwaters
pushed a commit
that referenced
this pull request
Jul 14, 2021
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed a case from #6687 which appeared in a e2e testnet.
I've also added some tests but I'll admit that I'm unsure if there's perhaps a better way to test context handling.