statesync/event: emit statesync start/end event #6700
Merged
cmwaters merged 27 commits intotendermint:masterfrom Jul 22, 2021
Merged
statesync/event: emit statesync start/end event #6700cmwaters merged 27 commits intotendermint:masterfrom
cmwaters merged 27 commits intotendermint:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6700 +/- ##
==========================================
+ Coverage 62.31% 62.48% +0.17%
==========================================
Files 297 298 +1
Lines 39907 39962 +55
==========================================
+ Hits 24867 24972 +105
+ Misses 13280 13223 -57
- Partials 1760 1767 +7
|
alexanderbez
suggested changes
Jul 13, 2021
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
Left some preliminary comments. Great work @JayT106.
node/node.go
Outdated
| state, err := ssR.Sync(context.TODO(), config.DiscoveryTime) | ||
| if err != nil { | ||
| ssR.Logger.Error("state sync failed", "err", err) | ||
| ssR.GetLogger().Error("state sync failed", "err", err) |
Contributor
There was a problem hiding this comment.
codesmell. Don't log here. The reactor should log on error.
Contributor
Author
There was a problem hiding this comment.
but it is a different goroutine, the caller might not be able to receive the return error.
Contributor
Author
|
@alexanderbez thanks for the feedback, I will change/remove the logs. |
tychoish
suggested changes
Jul 13, 2021
48b78c8 to
d3f61ad
Compare
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
Great changes so far @JayT106. Almost there!
cmwaters
reviewed
Jul 14, 2021
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
Just a few syntax changes but otherwise good
alexanderbez
approved these changes
Jul 18, 2021
0655ea0 to
019e081
Compare
tychoish
approved these changes
Jul 20, 2021
Contributor
|
@JayT106 - when you get a moment do you mind resolving the conflicts here. Then we can get this merged |
d728550 to
3370cd0
Compare
cmwaters
reviewed
Jul 21, 2021
cmwaters
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6619 (comment)