Conversation
tychoish
approved these changes
Jun 9, 2021
Contributor
tychoish
left a comment
There was a problem hiding this comment.
We currently have a genesis state store within the node, which seems quirky without having more context. Is there a path to being able to avoid this? https://github.com/tendermint/tendermint/blob/master/node/node.go#L75
How much of the e2e failures does this account for? Should it be backported to 0.34?
node/setup.go
Outdated
| evidencePool, err := evidence.NewPool(logger, evidenceDB, sm.NewStore(stateDB), blockStore) | ||
| if err != nil { | ||
| return nil, nil, nil, err | ||
| return nil, nil, nil, fmt.Errorf("creating evidence pool: %v", err) |
Contributor
There was a problem hiding this comment.
I think this should be a %w
Contributor
Author
We probably don't need this since we can derive it from the genesis doc |
alexanderbez
approved these changes
Jun 9, 2021
Codecov Report
@@ Coverage Diff @@
## master #6563 +/- ##
==========================================
+ Coverage 61.03% 61.14% +0.11%
==========================================
Files 295 295
Lines 27868 27850 -18
==========================================
+ Hits 17008 17029 +21
+ Misses 9139 9108 -31
+ Partials 1721 1713 -8
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After observing a few failed e2e tests I realised that I missed an edge case (when genesis has no validators) for this PR: #6554.