rpc: clean up client global state in tests#6438
Merged
tychoish merged 9 commits intotendermint:masterfrom May 11, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6438 +/- ##
==========================================
- Coverage 60.92% 60.88% -0.05%
==========================================
Files 287 287
Lines 27087 27087
==========================================
- Hits 16502 16491 -11
- Misses 8883 8895 +12
+ Partials 1702 1701 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6424
While there might additional improvements to these tests, this removes
three major cases of shared global state between tests.