Skip to content

rpc: remove global state in variables.  #6424

@tychoish

Description

@tychoish

There are a couple of places in the RPC package that depend on global variables which ought to be removed and replaced with more explicitly managed states.

  • the nodein the client test package should be replaced in individual tests with the appropriate fixtures.
  • in the core service package env should be constructable, and all of the dependencies should become methods. This means that the routes will also have to have a dependency on the environment.

This is in support, though somewhat tangentially, of preparing the public API for general consumption.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C:rpcComponent: JSON RPC, gRPCT:jankType Jank! Non-urgent but still high-impact fixes.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions