-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
C:rpcComponent: JSON RPC, gRPCComponent: JSON RPC, gRPCT:jankType Jank! Non-urgent but still high-impact fixes.Type Jank! Non-urgent but still high-impact fixes.
Description
There are a couple of places in the RPC package that depend on global variables which ought to be removed and replaced with more explicitly managed states.
- the nodein the client test package should be replaced in individual tests with the appropriate fixtures.
- in the core service package env should be constructable, and all of the dependencies should become methods. This means that the routes will also have to have a dependency on the environment.
This is in support, though somewhat tangentially, of preparing the public API for general consumption.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C:rpcComponent: JSON RPC, gRPCComponent: JSON RPC, gRPCT:jankType Jank! Non-urgent but still high-impact fixes.Type Jank! Non-urgent but still high-impact fixes.