Merged
Conversation
alexanderbez
commented
Apr 29, 2021
tac0turtle
approved these changes
Apr 29, 2021
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
LGTM.
Are we fine with this breaking change for 0.35?
Contributor
|
FYI it is less breaking than it appears. https://developers.google.com/protocol-buffers/docs/proto#updating
So anyone who didn't have trouble earlier (passing in utf8) will not even notice the change and can use 0.35 without updating their protobuf defs abci side |
Codecov Report
@@ Coverage Diff @@
## master #6408 +/- ##
==========================================
+ Coverage 60.93% 60.96% +0.02%
==========================================
Files 283 283
Lines 27012 26993 -19
==========================================
- Hits 16461 16457 -4
+ Misses 8829 8824 -5
+ Partials 1722 1712 -10
|
tychoish
pushed a commit
to tychoish/tendermint
that referenced
this pull request
May 5, 2021
4 tasks
3 tasks
thanethomson
added a commit
that referenced
this pull request
Aug 30, 2022
* types: Refactor EventAttribute (#6408) Cherry-pick of 09a6ad7 * Ensure context is honored Signed-off-by: Thane Thomson <connect@thanethomson.com> * Replace with tagged switch Signed-off-by: Thane Thomson <connect@thanethomson.com> * Ensure contexts are honored Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add UPGRADING note about type change Signed-off-by: Thane Thomson <connect@thanethomson.com> * Remove unnecessary conversion Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #6403