config: create BootstrapPeers p2p config parameter#6372
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6372 +/- ##
=======================================
Coverage 60.67% 60.68%
=======================================
Files 283 283
Lines 26925 26929 +4
=======================================
+ Hits 16337 16341 +4
- Misses 8884 8887 +3
+ Partials 1704 1701 -3
|
alexanderbez
approved these changes
Apr 20, 2021
Contributor
alexanderbez
left a comment
There was a problem hiding this comment.
Nice! This can't be hooked up until the seed work/pex v2 is complete, right?
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
cmwaters
commented
Apr 20, 2021
| if err != nil { | ||
| return nil, fmt.Errorf("invalid peer address %q: %w", p, err) | ||
| } | ||
| peers = append(peers, address) |
Contributor
Author
There was a problem hiding this comment.
It gets added to the peer manager here before we even start the pex reactor @alexanderbez
Contributor
There was a problem hiding this comment.
Yup, this looks correct!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #6363