Skip to content

config: reuse Seeds p2p config parameter as initial peers to connect with #6363

@cmwaters

Description

@cmwaters

Summary

Since seed nodes aren't treated any differently in a system, the P2PConfig.Seeds parameter is unused.

Proposal

Nodes need to be able to bootstrap to a few peers on start up such that they can run the PEX reactor with and get addresses of the nodes in the network. Currently, we use P2PConfig.PersistentPeers to add nodes. However persistent peers have a special use, nodes that we persistently want a connection with. I propose that we use P2PConfig.Seeds to be a list of peers that we add to the peer store on startup. There are no guarantees that the node will remain connected with these initial peers.

I personally think prior users can still think of P2PConfig.Seeds in a same way and that there won't be much confusion. If others think differently then perhaps we can make this as a new config parameter: P2PConfig.InitialPeers or P2PConfig.BootstrapPeers.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions