p2p: minor cleanup + update router options#6353
Merged
alexanderbez merged 7 commits intomasterfrom Apr 14, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6353 +/- ##
=======================================
Coverage 60.80% 60.81%
=======================================
Files 282 282
Lines 26885 26901 +16
=======================================
+ Hits 16347 16359 +12
- Misses 8835 8836 +1
- Partials 1703 1706 +3
|
alexanderbez
commented
Apr 13, 2021
| # functionality with a single network. | ||
|
|
||
| initial_height = 1000 | ||
| disable_legacy_p2p = false |
Contributor
Author
There was a problem hiding this comment.
You can ignore most of these changes. My vsc TOML extension automatically sorts :)
Contributor
There was a problem hiding this comment.
maybe we should all be running that extension, tbh
Contributor
Author
There was a problem hiding this comment.
yah I think we should ^__^
57 tasks
cmwaters
approved these changes
Apr 14, 2021
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
LGTM
Question: For v0.35 is the default the new p2p stack or the legacy one (I see currently that it's the legacy one but just wanting to make sure we are explicit about this)?
Contributor
Author
|
Good question @cmwaters -- I'm not sure tbh. |
tychoish
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to address the point
Merge MaxNumInboundPeers and MaxNumOutboundPeers into MaxConnections.from the p2p tracking issue, but realized we cannot remove those fields until we remove all of the legacy stack.So this PR just tweaks the current router options to use both max in and out plus some minor cleanup:
MaxIncomingConnectionAttemptsconfigMaxConnectionsconfig (will replaceMaxNumInboundPeersandMaxNumOutboundPeers)/cc @tessr