tooling: remove tools/Makefile (bp #6102)#6106
Merged
tac0turtle merged 4 commits intov0.34.xfrom Feb 12, 2021
Merged
Conversation
Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com> (cherry picked from commit 2d57043) # Conflicts: # CONTRIBUTING.md # Makefile # tools.mk
tac0turtle
approved these changes
Feb 12, 2021
Closed
tessr
added a commit
that referenced
this pull request
Feb 18, 2021
tessr
added a commit
that referenced
this pull request
Feb 18, 2021
tessr
added a commit
that referenced
this pull request
Feb 23, 2021
This reverts commit afd0709. I had believed that this tooling change could have been what broke our GoReleaser flow; I now know that it was a result of changes in Go 1.16 and an update to GoReleaser! GoReleaser has now been updated again and our flow should be un-broken.
tessr
added a commit
that referenced
this pull request
Feb 23, 2021
This reverts commit afd0709. I had believed that this tooling change could have been what broke our GoReleaser flow; I now know that it was a result of changes in Go 1.16 and an update to GoReleaser! GoReleaser has now been updated again and our flow should be un-broken.
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #6102 done by Mergify.
Cherry-pick of 2d57043 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/