Skip to content

node: improve test coverage on proposal block#5748

Merged
mergify[bot] merged 7 commits intomasterfrom
callum/proposal_tests
Dec 7, 2020
Merged

node: improve test coverage on proposal block#5748
mergify[bot] merged 7 commits intomasterfrom
callum/proposal_tests

Conversation

@cmwaters
Copy link
Contributor

@cmwaters cmwaters commented Dec 4, 2020

Description

Closes: #3156

@cmwaters cmwaters marked this pull request as ready for review December 7, 2020 16:35
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cmwaters cmwaters added the S:automerge Automatically merge PR when requirements pass label Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #5748 (f758204) into master (0d108ad) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5748   +/-   ##
=======================================
  Coverage   60.48%   60.49%           
=======================================
  Files         259      259           
  Lines       23334    23334           
=======================================
+ Hits        14114    14116    +2     
+ Misses       7754     7751    -3     
- Partials     1466     1467    +1     
Impacted Files Coverage Δ
blockchain/v0/reactor.go 62.56% <0.00%> (-1.98%) ⬇️
blockchain/v0/pool.go 78.22% <0.00%> (-0.74%) ⬇️
p2p/pex/pex_reactor.go 78.86% <0.00%> (-0.60%) ⬇️
consensus/state.go 68.40% <0.00%> (-0.38%) ⬇️
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
consensus/reactor.go 78.11% <0.00%> (+1.50%) ⬆️
crypto/sr25519/pubkey.go 52.17% <0.00%> (+8.69%) ⬆️

@mergify mergify bot merged commit b35e9ff into master Dec 7, 2020
@mergify mergify bot deleted the callum/proposal_tests branch December 7, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve tests for CreateProposalBlock

3 participants