-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
C:consensusComponent: ConsensusComponent: ConsensusC:mempoolComponent: MempoolComponent: MempoolT:jankType Jank! Non-urgent but still high-impact fixes.Type Jank! Non-urgent but still high-impact fixes.T:testType: Tests that need loveType: Tests that need lovegood first issueContributions Welcome!!Contributions Welcome!!
Description
Follow up to #2806, see the tests in
Line 202 in 0726329
| func TestCreateProposalBlock(t *testing.T) { |
Improvements to be made include:
- use real evidence for different blockIDs instead of introducing this new mock evidence
- ensure the Commit and Header are at maximum size
- confirm this would have caught Method of deciding amino overhead of tx in ReapMaxBytesMaxGas is wrong #2789
- tests with more variability in the block structure
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C:consensusComponent: ConsensusComponent: ConsensusC:mempoolComponent: MempoolComponent: MempoolT:jankType Jank! Non-urgent but still high-impact fixes.Type Jank! Non-urgent but still high-impact fixes.T:testType: Tests that need loveType: Tests that need lovegood first issueContributions Welcome!!Contributions Welcome!!