Conversation
previously, the second next could return nil, which would be the reason for panic on line 275: memTx := next.Value.(*mempoolTx) Closes #5408
Codecov Report
@@ Coverage Diff @@
## master #5412 +/- ##
==========================================
+ Coverage 61.24% 61.28% +0.04%
==========================================
Files 259 259
Lines 23437 23438 +1
==========================================
+ Hits 14354 14364 +10
+ Misses 7625 7619 -6
+ Partials 1458 1455 -3
|
erikgrinaker
approved these changes
Sep 28, 2020
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Makes sense. Have we verified that there aren't any other races here?
tac0turtle
reviewed
Sep 28, 2020
This comment has been minimized.
This comment has been minimized.
erikgrinaker
approved these changes
Sep 29, 2020
| // regression test for https://github.com/tendermint/tendermint/issues/5408 | ||
| func TestReactorConcurrency(t *testing.T) { | ||
| config := cfg.TestConfig() | ||
| const N = 2 |
Contributor
There was a problem hiding this comment.
What does this actually do? Seems like we're only testing two reactors regardless of this setting, in which case I think we can just drop this constant.
Contributor
Author
There was a problem hiding this comment.
we use it when creating reactors makeAndConnectReactors. the number can be increased to 4 for example. 2 is only required when we want to assert the order of transactions on the receiving side
Contributor
There was a problem hiding this comment.
Sure, but what purpose would it serve to start more reactors than the two we're testing?
Contributor
Author
There was a problem hiding this comment.
I can't think of any
Merged
1 task
melekes
added a commit
that referenced
this pull request
Sep 30, 2020
previously, the second next could return nil, which would be the reason for panic on line 275: memTx := next.Value.(*mempoolTx) Closes #5408
boxi11
added a commit
to boxi11/tendermint
that referenced
this pull request
Sep 30, 2020
* mempool: fix nil pointer dereference (tendermint#5412) previously, the second next could return nil, which would be the reason for panic on line 275: memTx := next.Value.(*mempoolTx) Closes tendermint#5408 * docs: specify TM version in go tutorials (tendermint#5427) Closes tendermint#5425 * privval: allow passing options to NewSignerDialerEndpoint (tendermint#5434) Required for tendermint#5291 to set timeouts for remote signers. Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Erik Grinaker <erik@interchain.berlin>
This was referenced Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, the second next could return nil, which would be the reason
for panic on line 275:
memTx := next.Value.(*mempoolTx)
Closes #5408