Skip to content

minor tweaks#5404

Merged
melekes merged 5 commits intomasterfrom
anton/openapi
Sep 25, 2020
Merged

minor tweaks#5404
melekes merged 5 commits intomasterfrom
anton/openapi

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Sep 25, 2020

No description provided.

@melekes melekes marked this pull request as ready for review September 25, 2020 06:20
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #5404 into master will increase coverage by 1.70%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5404      +/-   ##
==========================================
+ Coverage   59.60%   61.31%   +1.70%     
==========================================
  Files         202      259      +57     
  Lines       17491    23417    +5926     
==========================================
+ Hits        10426    14357    +3931     
- Misses       6000     7599    +1599     
- Partials     1065     1461     +396     
Impacted Files Coverage Δ
consensus/state.go 68.41% <100.00%> (+0.56%) ⬆️
blockchain/v0/pool.go 76.01% <0.00%> (-0.74%) ⬇️
proxy/multi_app_conn.go 48.64% <0.00%> (ø)
p2p/conn_set.go 95.23% <0.00%> (ø)
privval/retry_signer_client.go 0.00% <0.00%> (ø)
privval/signer_dialer_endpoint.go 96.00% <0.00%> (ø)
privval/signer_client.go 53.06% <0.00%> (ø)
mempool/metrics.go 15.15% <0.00%> (ø)
libs/tempfile/tempfile.go 79.48% <0.00%> (ø)
light/rpc/proof.go 0.00% <0.00%> (ø)
... and 53 more


Other user-relevant changes include:

* The old `lite` package was removed; the new light client uses the `light` package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to include that the light client verifies and stores light blocks instead of signed headers and validator sets (probably covered somewhere else but I feel like it also makes sense to put it here as well)

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes merged commit 7d2b3e3 into master Sep 25, 2020
@melekes melekes deleted the anton/openapi branch September 25, 2020 07:05
sergio-mena pushed a commit that referenced this pull request Aug 25, 2022
* docs: fix /validators description

Refs tendermint/spec#169

* consensus: remove nil err from logging statement

* update UPGRADING.md

* note about LightBlocks
sergio-mena added a commit that referenced this pull request Aug 26, 2022
….md`. Reworked `UPGRADING.md` (#9315)

* master-->main in `CONTRIBUTING.md`

* Added feature branches in `CONTRIBUTING.md`

* Fixes to `UPGRADING.md`

* [cherrypicked] docs: minor tweaks (#5404)

* docs: fix /validators description

Refs tendermint/spec#169

* consensus: remove nil err from logging statement

* update UPGRADING.md

* note about LightBlocks

* Reworked "Unreleased" section of `UPGRADING.md`

* Added PrepareProposal and ProcessProposal to `CHANGELOG_PENDING.md`

* Apply suggestions from @thanethomson's code review

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Addressed @tychoish's comment

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants