Skip to content

blockstore: fix race conditions when loading data#5382

Merged
melekes merged 8 commits intomasterfrom
erik/block-pruning-concurrency
Sep 23, 2020
Merged

blockstore: fix race conditions when loading data#5382
melekes merged 8 commits intomasterfrom
erik/block-pruning-concurrency

Conversation

@erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Sep 22, 2020

Fixes #5377 and comments in #4588 (review).

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #5382 into master will increase coverage by 0.45%.
The diff coverage is 40.57%.

@@            Coverage Diff             @@
##           master    #5382      +/-   ##
==========================================
+ Coverage   60.83%   61.29%   +0.45%     
==========================================
  Files         203      259      +56     
  Lines       20526    23385    +2859     
==========================================
+ Hits        12488    14333    +1845     
- Misses       6961     7594     +633     
- Partials     1077     1458     +381     
Impacted Files Coverage Δ
abci/client/grpc_client.go 0.00% <0.00%> (ø)
abci/example/kvstore/persistent_kvstore.go 40.49% <0.00%> (-5.22%) ⬇️
blockchain/v2/processor_context.go 68.00% <0.00%> (+4.84%) ⬆️
cmd/tendermint/commands/lite.go 19.16% <0.00%> (-0.35%) ⬇️
cmd/tendermint/commands/reset_priv_validator.go 3.44% <0.00%> (-2.44%) ⬇️
cmd/tendermint/commands/run_node.go 0.00% <0.00%> (ø)
config/toml.go 60.97% <ø> (-4.99%) ⬇️
consensus/replay_file.go 0.00% <0.00%> (ø)
consensus/replay_stubs.go 57.57% <ø> (-3.30%) ⬇️
consensus/wal.go 60.86% <0.00%> (-5.99%) ⬇️
... and 289 more

@erikgrinaker erikgrinaker changed the title blockstore: handle missing block parts in LoadBlock blockstore: fix race conditions when loading data Sep 22, 2020
@erikgrinaker erikgrinaker marked this pull request as ready for review September 22, 2020 14:08
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes merged commit 58b4dec into master Sep 23, 2020
@melekes melekes deleted the erik/block-pruning-concurrency branch September 23, 2020 06:13
kostko pushed a commit to oasisprotocol/tendermint that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Concurrency issue with block store

2 participants