proto: add proto files for ibc unblock (#4853)#4906
Merged
tac0turtle merged 1 commit intorc2/v0.33.5from May 27, 2020
Merged
Conversation
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
these proto files are meant to help unblock ibc in their quest of migrating the ibc module to proto. Closes: #XXX
130800f to
50fcee9
Compare
Codecov Report
@@ Coverage Diff @@
## rc2/v0.33.5 #4906 +/- ##
===============================================
- Coverage 66.19% 65.58% -0.62%
===============================================
Files 247 172 -75
Lines 22300 14305 -7995
===============================================
- Hits 14762 9382 -5380
+ Misses 6372 4159 -2213
+ Partials 1166 764 -402
|
melekes
approved these changes
May 27, 2020
fedekunze
approved these changes
May 27, 2020
Comment on lines
+275
to
+278
| {"success empty", &BitArray{}, true}, | ||
| {"success", NewBitArray(1), true}, | ||
| {"success", NewBitArray(2), true}, | ||
| {"negative", NewBitArray(-1), false}, |
Contributor
There was a problem hiding this comment.
add a test with NewBitArray(0)?
Contributor
Author
There was a problem hiding this comment.
I will make the change to this test on master, that work?
| if commit.Round < 0 { | ||
| return errors.New("negative Round") | ||
| } | ||
| if commit.Height >= 1 { |
Contributor
There was a problem hiding this comment.
nit, use inverse for better readability
if commit.Height < 1 {
return nil
}
if commit.BlockID.IsZero() {
return errors.New("commit cannot be for nil block")
}
...
Contributor
There was a problem hiding this comment.
no, you can't do that. commit.Height < 1 does not make the whole commit valid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
these proto files are meant to help unblock ibc in their quest of migrating the ibc module to proto.
Closes: #XXX