mempool: allow ReapX and CheckTx functions to run in parallel#4759
Merged
mergify[bot] merged 12 commits intomasterfrom May 8, 2020
Merged
mempool: allow ReapX and CheckTx functions to run in parallel#4759mergify[bot] merged 12 commits intomasterfrom
mergify[bot] merged 12 commits intomasterfrom
Conversation
if you look at the code, you'll discover that it's never used. consensus locks the whole mempool proxyMtx for the duration of Update (including rechecking). Note both ReapMaxBytesMaxGas and ReapMaxTxs try to lock the same mutex.
ReapMaxBytesMaxGas,ReapMaxTxs,CheckTx can now run in parallel. Update and ^ cannot run in parallel, thus preserving safety. Closes #2972
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #4759 +/- ##
=======================================
Coverage 64.78% 64.78%
=======================================
Files 241 241
Lines 23053 23062 +9
=======================================
+ Hits 14934 14941 +7
- Misses 6901 6905 +4
+ Partials 1218 1216 -2
|
tac0turtle
reviewed
Apr 28, 2020
erikgrinaker
reviewed
May 4, 2020
erikgrinaker
reviewed
May 6, 2020
| if (r.CheckTx.Code == abci.CodeTypeOK) && postCheckErr == nil { | ||
| // Check mempool isn't full again to reduce the chance of exceeding the | ||
| // limits. | ||
| if err := mem.isFull(len(tx)); err != nil { |
Contributor
There was a problem hiding this comment.
Maybe we should wrap this in a mutex to serialize the checks? It will be serialized by the mutex in addTx() anyway, so serializing here as well shouldn't incur any additional cost.
Contributor
Author
There was a problem hiding this comment.
serializing here as well shouldn't incur any additional cost.
not sure we will get much by doing that
There was a problem hiding this comment.
It could cause missing transaction that BroadcastTxSync() returns a success (code = 0) but the tx is not added to mempool.
erikgrinaker
approved these changes
May 7, 2020
5 tasks
jinsan-line
added a commit
to Finschia/ostracon
that referenced
this pull request
Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow ReapX and CheckTx functions to run in parallel, making it not possible to block certain proposers from creating a new block.
Closes: #2972