Skip to content

evidence: both MaxAgeDuration and MaxAgeNumBlocks need to be surpassed#4667

Merged
melekes merged 3 commits intomasterfrom
anton/evidence-age-check
Apr 14, 2020
Merged

evidence: both MaxAgeDuration and MaxAgeNumBlocks need to be surpassed#4667
melekes merged 3 commits intomasterfrom
anton/evidence-age-check

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Apr 14, 2020

Refs #2565 (comment)
Refs #2653
spec PR: tendermint/spec#87

Description

for evidence to be considered expired. otherwise, a cabal group can
manipulate block time to make a particular evidence too old.


For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

for evidence to be considered expired. otherwise, a cabal group can
  manipulate block time to make a particular evidence too old.
@melekes melekes requested a review from tessr as a code owner April 14, 2020 06:46
@melekes melekes self-assigned this Apr 14, 2020
@melekes melekes added the C:evidence Component: Evidence label Apr 14, 2020
@melekes
Copy link
Contributor Author

melekes commented Apr 14, 2020

spec PR: tendermint/spec#87

@melekes melekes added the T:security Type: Security (specify priority) label Apr 14, 2020
@melekes melekes merged commit 11fa625 into master Apr 14, 2020
@melekes melekes deleted the anton/evidence-age-check branch April 14, 2020 10:58
tac0turtle pushed a commit that referenced this pull request Apr 29, 2020
#4667)

for evidence to be considered expired. otherwise, a cabal group can
  manipulate block time to make a particular evidence too old.

Refs #2565 (comment)
Refs #2653
spec PR: tendermint/spec#87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:evidence Component: Evidence T:security Type: Security (specify priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants