Conversation
Codecov Report
@@ Coverage Diff @@
## master #4397 +/- ##
==========================================
- Coverage 65.67% 65.65% -0.03%
==========================================
Files 225 225
Lines 19952 19951 -1
==========================================
- Hits 13104 13099 -5
- Misses 5792 5794 +2
- Partials 1056 1058 +2
|
cmwaters
approved these changes
Feb 13, 2020
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
Do we need to add anything about the sequential or bisection methods?
Other than that, it looks good to me
Contributor
Author
don't see a need to duplicate https://pkg.go.dev/github.com/tendermint/tendermint/lite2?tab=doc#SequentialVerification |
Contributor
|
Okay, perhaps reference it? Or I guess it's fine if you don’t
… On 13/02/2020, at 5:23 PM, Anton Kaliaev ***@***.***> wrote:
Do we need to add anything about the sequential or bisection methods?
don't see a need to duplicate https://pkg.go.dev/github.com/tendermint/tendermint/lite2?tab=doc#SequentialVerification <https://pkg.go.dev/github.com/tendermint/tendermint/lite2?tab=doc#SequentialVerification>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#4397?email_source=notifications&email_token=AGRPDZS7JDMRFCXJINHZVATRCVXWVA5CNFSM4KUPJUH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELVUBRQ#issuecomment-585842886>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGRPDZTTTKLRTVSNJEV5IELRCVXWVANCNFSM4KUPJUHQ>.
|
Contributor
Author
as per our discussion, I don't think ADR should be a reference to API, but merely an explanation why certain choices were made (like having >= 1 witness, etc.) |
Contributor
|
Ah okay, I guess I’m still understanding the exact purpose of adr‘s and the level of context that is required.
… On 14/02/2020, at 11:30 AM, Anton Kaliaev ***@***.***> wrote:
Okay, perhaps reference it?
as per our discussion, I don't think ADR should be a reference to API, but merely an explanation why certain choices were made (like having >= 1 witness, etc.)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 RENDERED
Closes #2133
Updated all code comments where relevantWrote testsUpdated CHANGELOG_PENDING.md