metrics: add metric for when commit is nil#4283
Merged
Conversation
- follow up to #4263 - when a commit is nil, then it should be counted as a missed commit Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
5 tasks
melekes
reviewed
Jan 6, 2020
Contributor
melekes
left a comment
There was a problem hiding this comment.
better to add ForBlock() func (BlockIDFlag == BlockIDFlagCommit)
tac0turtle
commented
Jan 6, 2020
melekes
approved these changes
Jan 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #4283 +/- ##
==========================================
+ Coverage 65.47% 65.56% +0.09%
==========================================
Files 225 225
Lines 19433 19422 -11
==========================================
+ Hits 12724 12735 +11
+ Misses 5726 5707 -19
+ Partials 983 980 -3
|
tac0turtle
added a commit
that referenced
this pull request
Jan 8, 2020
- follow up to #4263 - when a commit is nil, then it should be counted as a missed commit Signed-off-by: Marko Baricevic marbar3778@yahoo.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marko Baricevic marbar3778@yahoo.com