Skip to content

Fix build instructions#4123

Merged
melekes merged 1 commit intotendermint:masterfrom
corollari:broken-wiki
Nov 10, 2019
Merged

Fix build instructions#4123
melekes merged 1 commit intotendermint:masterfrom
corollari:broken-wiki

Conversation

@corollari
Copy link
Contributor

@corollari corollari commented Nov 9, 2019

Currently the documentation on installing tendermint from source references the now-gone repository wiki, which leads to those links being broken. This PR fixes that by just inlining the content that was in the wiki.

Furthermore, building tendermint with just the instructions provided results in the following error:

Get Certstrap
go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'
go: cannot use path@version syntax in GOPATH mode
make: *** [tools.mk:62: /home/corollari/go/bin/certstrap] Error 1

This PR fixes that by also setting the GO111MODULE environment variable.

@codecov-io
Copy link

codecov-io commented Nov 9, 2019

Codecov Report

Merging #4123 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #4123     +/-   ##
=========================================
+ Coverage   66.57%   66.67%   +0.1%     
=========================================
  Files         247      247             
  Lines       21218    21220      +2     
=========================================
+ Hits        14126    14149     +23     
+ Misses       6036     6019     -17     
+ Partials     1056     1052      -4
Impacted Files Coverage Δ
consensus/reactor.go 77.1% <0%> (-0.93%) ⬇️
blockchain/v0/reactor.go 78.77% <0%> (-0.76%) ⬇️
consensus/replay.go 72.54% <0%> (+0.78%) ⬆️
p2p/pex/pex_reactor.go 83.86% <0%> (+1.72%) ⬆️
privval/signer_listener_endpoint.go 89.13% <0%> (+2.17%) ⬆️
types/tx.go 91.3% <0%> (+4.34%) ⬆️
privval/signer_server.go 100% <0%> (+4.34%) ⬆️
privval/signer_endpoint.go 83.78% <0%> (+8.1%) ⬆️
blockchain/v2/reactor.go 70.17% <0%> (+19.29%) ⬆️

tac0turtle
tac0turtle approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, we are loving these ❤️

melekes
melekes approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melekes melekes merged commit 6a46082 into tendermint:master Nov 10, 2019
iKapitonau pushed a commit to scrtlabs/tendermint that referenced this pull request Mar 3, 2025
@mergify @yihuang @andynog
fix(mempool): change "mempool is full" log level to debug (backport t…
fdf90d1 
…endermint#4123) (tendermint#4145)

it happens in benchmark or production when traffic is high, the log
frequency is very high because it's triggered by p2p tx propagation
message.

Solution:
- change it to debug level
<hr>This is an automatic backport of pull request tendermint#4123 done by
[Mergify](https://mergify.com).

---------

Co-authored-by: yihuang <yi.codeplayer@gmail.com>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@tessr tessr Awaiting requested review from tessr

2 more reviewers

@melekes melekes melekes approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corollari @codecov-io @melekes @tac0turtle