Merged
Conversation
tac0turtle
approved these changes
Oct 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #4045 +/- ##
==========================================
+ Coverage 67.14% 67.15% +0.01%
==========================================
Files 245 245
Lines 20576 20575 -1
==========================================
+ Hits 13816 13818 +2
+ Misses 5724 5722 -2
+ Partials 1036 1035 -1
|
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
) ### Context The project has a transitive dependency on an old version of [golang.org/x/image](https://pkg.go.dev/golang.org/x/image), which is vulnerable to [CVE-2024-24792](https://nvd.nist.gov/vuln/detail/CVE-2024-24792), [CVE-2023-29407](https://nvd.nist.gov/vuln/detail/CVE-2023-29407), [CVE-2023-29408](https://nvd.nist.gov/vuln/detail/CVE-2023-29408), and [CVE-2022-41727](https://nvd.nist.gov/vuln/detail/CVE-2022-41727). ### This Change This PR updates the version of a direct CometBFT dependency (`gonum.org/v1/gonum`) that depends on `golang.org/x/image`, thus causing the transitive dependency. This forces an update of `golang.org/x/image` to a newer version unaffected by vulnerabilities. --- #### PR checklist ~- [ ] Tests written/updated~ - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
indexing-transactions.mdto reflect new Events semantics. Note, we should probably update the config.toml to replace tags with events verbiage.