Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #395 +/- ##
==========================================
Coverage ? 50.48%
==========================================
Files ? 37
Lines ? 4437
Branches ? 0
==========================================
Hits ? 2240
Misses ? 1981
Partials ? 216Continue to review full report at Codecov.
|
0be18a4 to
cf525fa
Compare
813Mb => 29.5Mb
cf525fa to
bf64dd2
Compare
Closed
cmwaters
pushed a commit
that referenced
this pull request
Feb 11, 2022
thanethomson
pushed a commit
that referenced
this pull request
Aug 12, 2022
thanethomson
added a commit
that referenced
this pull request
Aug 12, 2022
cmwaters
pushed a commit
that referenced
this pull request
Aug 19, 2022
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
Contributes to #93 and #41 [Rendered](https://github.com/cometbft/cometbft/blob/sergio/qa_0.37.x-alpha3_baseline_plots/docs/qa/v037/CometBFT.md) Complementary to #376 (and analogous to what we did for CometBFT `v0.34.x` QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts. The goal is to ease visual comparison between CometBFT `v0.37.x` and Tendermint Core baseline results when looking at the report. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments
adrianbrink
pushed a commit
to heliaxdev/tendermint
that referenced
this pull request
May 23, 2023
…dermint#401) Contributes to #93 and #41 [Rendered](https://github.com/cometbft/cometbft/blob/sergio/qa_0.37.x-alpha3_baseline_plots/docs/qa/v037/CometBFT.md) Complementary to tendermint#376 (and analogous to what we did for CometBFT `v0.34.x` QA) this PR re-plots the baseline results, obtained in Oct 2022, using the newly developed python scripts. The goal is to ease visual comparison between CometBFT `v0.37.x` and Tendermint Core baseline results when looking at the report. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit c67d2f7) Co-authored-by: Sergio Mena <sergio@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
813Mb => 29.5Mb 😋
Re(push) image: