Skip to content

Improve CircleCI setup (WIP)#394

Merged
ebuchman merged 1 commit intodevelopfrom
feature/improve-circleci-setup
Feb 7, 2017
Merged

Improve CircleCI setup (WIP)#394
ebuchman merged 1 commit intodevelopfrom
feature/improve-circleci-setup

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Feb 3, 2017

Refs #387

@melekes melekes force-pushed the feature/improve-circleci-setup branch 3 times, most recently from 843b146 to aaa6548 Compare February 3, 2017 15:43
@codecov-io
Copy link

codecov-io commented Feb 3, 2017

Codecov Report

❗ No coverage uploaded for pull request base (develop@36b5d86). Click here to learn what that means.

@@            Coverage Diff             @@
##             develop     #394   +/-   ##
==========================================
  Coverage           ?   51.25%           
==========================================
  Files              ?       37           
  Lines              ?     4437           
  Branches           ?        0           
==========================================
  Hits               ?     2274           
  Misses             ?     1945           
  Partials           ?      218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b5d86...d5d7286. Read the comment docs.

@melekes melekes force-pushed the feature/improve-circleci-setup branch 6 times, most recently from 698f218 to 5fb84eb Compare February 3, 2017 18:21
- update docker machine version to 0.9.0
- save coverage.txt as artifact
- save docker logs as artifact
- test if coverage.txt exists
- 2>&1 redirect stderr to stdout in tests
@ebuchman
Copy link
Contributor

ebuchman commented Feb 7, 2017

Cool. So does /var/log/upstart/docker.log contain the output from all the docker containers that ran? I would have though it's just for the daemon

@melekes
Copy link
Contributor Author

melekes commented Feb 7, 2017

No :) it's just for the daemon.. see #387 (comment)

@ebuchman ebuchman merged commit 77cc15a into develop Feb 7, 2017
@ebuchman ebuchman mentioned this pull request Feb 14, 2017
@ebuchman ebuchman deleted the feature/improve-circleci-setup branch April 19, 2017 02:35
cmwaters added a commit that referenced this pull request Feb 11, 2022
#394)

* p2p/message: Changed evidence message to contain evidence, not a list of evidence

* Update spec/p2p/messages/evidence.md

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants