Merged
Conversation
melekes
reviewed
Aug 1, 2019
| expectErr bool | ||
| }{ | ||
| {"Too Many Channels", func(ni *DefaultNodeInfo) { ni.Channels = append(channels, byte(maxNumChannels)) }, true}, | ||
| {"Too Many Channels", func(ni *DefaultNodeInfo) { ni.Channels = append(channels, byte(maxNumChannels)) }, true}, // nolint: gocritic |
Contributor
There was a problem hiding this comment.
curious what's wrong with append?
Codecov Report
@@ Coverage Diff @@
## master #3864 +/- ##
==========================================
+ Coverage 66.01% 66.06% +0.04%
==========================================
Files 234 234
Lines 20265 20277 +12
==========================================
+ Hits 13378 13396 +18
- Misses 5818 5832 +14
+ Partials 1069 1049 -20
|
tac0turtle
added a commit
that referenced
this pull request
Aug 2, 2019
This reverts commit f9cce28.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3262