Merged
Conversation
- update golang to 1.7.4 - version as env variable - change DATA_ROOT from /tendermint/data to /tendermint (it's not just data that gets stored in DATA_ROOT; we create data folder on start; as a result we get /tendermint/data/data, which is confusing) - remove noninteractive env vars (do we really need these?) - remove nodejs dep (some apps may require nodejs, but core is not one of them; it was convenient before, but now I believe we ought to remove it because other people who are using java do not want a bloated container with nodejs) - build tendermint inside a container (once again, it was convenient before, but now I am testing kubernetes and I don't want to wait every time TM compiles)
Closed
troian
pushed a commit
to akash-network/tendermint
that referenced
this pull request
Mar 11, 2023
* docs: Add upgrading guidelines for CometBFT v0.34.27 Signed-off-by: Thane Thomson <connect@thanethomson.com> * Expand on env vars fallback support Signed-off-by: Thane Thomson <connect@thanethomson.com> * docs: Add upgrading guidelines to v0.34.x docs Signed-off-by: Thane Thomson <connect@thanethomson.com> * docs: Update docs intro root with upgrading guidelines link Signed-off-by: Thane Thomson <connect@thanethomson.com> * Add note on Go module URL and historical upgrading instructions link Signed-off-by: Thane Thomson <connect@thanethomson.com> * docs: Sync with upgrading root doc Signed-off-by: Thane Thomson <connect@thanethomson.com> * Update UPGRADING.md * Adds a note about the use of go 1.19 --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data that gets stored in DATA_ROOT; we create data folder on start; as
a result we get /tendermint/data/data, which is confusing)
of them; it was convenient before, but now I believe we ought to
remove it because other people who are using java do not want a
bloated container with nodejs)
before, but now I am testing kubernetes and I don't want to wait every
time TM compiles)
Also, I want to suggest renaming the image to
tendermint/tendermint(it looks cleaner) and starting tagging it (tendermint/tendermint:0.8.0) as we push it: