Skip to content

Output all tendermint commands#379

Merged
ebuchman merged 2 commits intotendermint:developfrom
melekes:feature/output-all-tendermint-commands
Jan 28, 2017
Merged

Output all tendermint commands#379
ebuchman merged 2 commits intotendermint:developfrom
melekes:feature/output-all-tendermint-commands

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Jan 24, 2017 •
edited
Loading

I find it very confusing when I am going through the tutorial (https://tendermint.com/intro/getting-started/install) and do not see init in the list of available commands.

Also, now we just dump all the flags, even whose not relevant to the given command:

./build/tendermint replay wal --gee
unknown flag: --gee
Usage of main:
      --abci string         Specify abci transport (socket | grpc) (default "socket")
      --fast_sync           Fast blockchain syncing (default true)
      --grpc_laddr string   GRPC listen address (BroadcastTx only). Port required
      --help                Print this help message.
      --log_level string    Log level (default "notice")
      --moniker string      Node Name (default "anonymous")
      --node_laddr string   Node listen address. (0.0.0.0:0 means any interface, anyport) (default "tcp://0.0.0.0:46656")
      --pex                 Enable Peer-Exchange (dev feature)
      --proxy_app string    Proxy app address, or 'nilapp' or 'dummy' for local testing. (default "tcp://127.0.0.1:46658")
      --rpc_laddr string    RPC listen address. Port required (default "tcp://0.0.0.0:46657")
      --seeds string        Comma delimited host:port seed nodes
      --skip_upnp           Skip UPNP configuration

I believe most of these belong to node. We should probably move to something like https://github.com/spf13/cobra

@melekes
output all commands
17e8227
@melekes
check that we have enough arguments
3b7a1d7 
Otherwise:

```
panic: runtime error: index out of range

goroutine 1 [running]:
panic(0xbb8de0, 0xc82000e080)
        /usr/local/go/src/runtime/panic.go:464 +0x3e6
main.main()
        /go/src/github.com/tendermint/tendermint/cmd/tendermint/main.go:48 +0x811
```
@ebuchman
Copy link
Contributor

ebuchman commented Jan 24, 2017

Thanks anton. I've assigned moving to spf13/cobra or urfave/cli to @rigelrozanski

@ebuchman ebuchman merged commit 3b7a1d7 into tendermint:develop Jan 28, 2017
@ebuchman ebuchman mentioned this pull request Feb 14, 2017
Closed
adrianbrink pushed a commit to heliaxdev/tendermint that referenced this pull request May 23, 2023
@mergify @thanethomson
ci: Remove Buf tokens from workflow (tendermint#378) (tendermint#379)
033bdbf 
* ci: Remove Buf tokens from workflow

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Format proto folder readme to trigger workflow

Signed-off-by: Thane Thomson <connect@thanethomson.com>

---------

Signed-off-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit 126f190)

Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@melekes @ebuchman