node: allow registration of custom reactors while creating node#3771
Merged
node: allow registration of custom reactors while creating node#3771
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3771 +/- ##
==========================================
- Coverage 64.04% 63.91% -0.13%
==========================================
Files 217 217
Lines 18129 18142 +13
==========================================
- Hits 11610 11595 -15
- Misses 5550 5573 +23
- Partials 969 974 +5
|
Contributor
Author
|
\cc @ParthDesai |
tac0turtle
approved these changes
Jul 3, 2019
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
Should this be added into the docs somewhere? 🥇
thanethomson
approved these changes
Jul 3, 2019
Contributor
thanethomson
left a comment
There was a problem hiding this comment.
Nice! 🎉
It's great how this solution doesn't break the Golang API 👍
Contributor
Truly fantastic.
Good question. I don't think we have explicit documentation for the Go APIs other than comments in the code. We should probably write a doc.go for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3730 (comment)
Replaces #3730
Updated all relevant documentation in docs