[node] allow registration of custom reactors while creating node#3730
Closed
ParthDesai wants to merge 4 commits intotendermint:masterfrom
Closed
[node] allow registration of custom reactors while creating node#3730ParthDesai wants to merge 4 commits intotendermint:masterfrom
ParthDesai wants to merge 4 commits intotendermint:masterfrom
Conversation
ParthDesai
commented
Jun 18, 2019
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG_PENDING.md
|
Loomchain uses custom reactor for gaming specific features. Would love to expose more of this portion of tendermint in the future |
Codecov Report
@@ Coverage Diff @@
## develop #3730 +/- ##
===========================================
+ Coverage 63.87% 63.94% +0.06%
===========================================
Files 241 241
Lines 19985 19989 +4
===========================================
+ Hits 12766 12781 +15
+ Misses 6171 6164 -7
+ Partials 1048 1044 -4
|
Contributor
|
Thank you for contributing this 👍 I think it's time to refactor |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.