Skip to content

remove confusing statement#3764

Merged
melekes merged 1 commit intotendermint:masterfrom
climber73:remove-confusing-statement
Jun 30, 2019
Merged

remove confusing statement#3764
melekes merged 1 commit intotendermint:masterfrom
climber73:remove-confusing-statement

Conversation

@climber73
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #3764 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3764      +/-   ##
==========================================
+ Coverage   63.96%   63.98%   +0.01%     
==========================================
  Files         242      242              
  Lines       20010    20010              
==========================================
+ Hits        12800    12804       +4     
- Misses       6162     6164       +2     
+ Partials     1048     1042       -6
Impacted Files Coverage Δ
p2p/pex/errors.go 11.11% <0%> (-11.12%) ⬇️
types/tx.go 86.95% <0%> (-4.35%) ⬇️
p2p/pex/pex_reactor.go 80.88% <0%> (-2.95%) ⬇️
privval/signer_service_endpoint.go 83.63% <0%> (-1.82%) ⬇️
p2p/pex/addrbook.go 67.5% <0%> (-0.5%) ⬇️
consensus/reactor.go 71.86% <0%> (+0.23%) ⬆️
consensus/state.go 79.97% <0%> (+0.23%) ⬆️
blockchain/pool.go 80.92% <0%> (+0.65%) ⬆️
consensus/replay.go 71.02% <0%> (+0.81%) ⬆️
privval/signer_remote.go 82% <0%> (+2%) ⬆️
... and 2 more

@melekes melekes merged commit d069eb6 into tendermint:master Jun 30, 2019
* `git fetch upstream`
* `git rebase upstream/master` (or whatever branch you want)

Please don't make Pull Requests to `master`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

cboh4 pushed a commit to scrtlabs/tendermint that referenced this pull request Apr 7, 2025
<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [ ] ~~Updated relevant documentation (`docs/` or `spec/`) and code
comments~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants