p2p: dial addrs which came from seed instead of calling ensurePeers#3762
Merged
p2p: dial addrs which came from seed instead of calling ensurePeers#3762
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3762 +/- ##
==========================================
+ Coverage 63.94% 63.98% +0.04%
==========================================
Files 217 217
Lines 18009 18094 +85
==========================================
+ Hits 11516 11578 +62
- Misses 5526 5546 +20
- Partials 967 970 +3
|
AdityaSripal
approved these changes
Jul 2, 2019
Closed
ruseinov
pushed a commit
to ruseinov/tendermint
that referenced
this pull request
Jul 26, 2019
…endermint#3762) Calling ensurePeers outside of ensurePeersRoutine can lead to nodes disconnecting from us due to "sent next PEX request too soon" error. Solution is to just dial addrs we got from src instead of calling ensurePeers. Refs tendermint#2093 Fixes tendermint#3338
This was referenced Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling ensurePeers outside of ensurePeersRoutine can lead to nodes
disconnecting from us due to "sent next PEX request too soon" error.
Solution is to just dial addrs we got from src instead of calling
ensurePeers.
Refs #2093
Fixes #3338