Update to contributing.md#3760
Merged
melekes merged 3 commits intotendermint:masterfrom Jun 28, 2019
tac0turtle:marko/minor-update-contributing
Merged
Update to contributing.md#3760melekes merged 3 commits intotendermint:masterfrom tac0turtle:marko/minor-update-contributing
melekes merged 3 commits intotendermint:masterfrom
tac0turtle:marko/minor-update-contributing
Conversation
- Add in section for Draft PR, instead of WIP - Add make lint as part of the commit process. Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## master #3760 +/- ##
=========================================
- Coverage 64.06% 63.96% -0.1%
=========================================
Files 242 242
Lines 19968 20010 +42
=========================================
+ Hits 12792 12800 +8
- Misses 6137 6164 +27
- Partials 1039 1046 +7
|
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
…rmint#3760) - 1) protos are now built with the sdk's proto builder - 2) go tools methodology just bloats .mod and .sum making comet harder to work with - 3) tidy: mod and sum don't have maintenance tools in them anymore - 4) stop using an abandoned Dockerfile --------- tl;dr: by removing things from go.mod we can make comet easier to maintain, even if that means less stylish golang. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments <hr>This is an automatic backport of pull request tendermint#2046 done by [Mergify](https://mergify.com). --------- Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marko Baricevic marbar3778@yahoo.com