Added a disclaimer so the user is aware of binary#3751
Merged
ebuchman merged 2 commits intotendermint:developfrom Jun 24, 2019
tac0turtle:marko/add_disclaimer-s-w
Merged
Added a disclaimer so the user is aware of binary#3751ebuchman merged 2 commits intotendermint:developfrom tac0turtle:marko/add_disclaimer-s-w
ebuchman merged 2 commits intotendermint:developfrom
tac0turtle:marko/add_disclaimer-s-w
Conversation
- added disclaimer for `-s -w` Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## develop #3751 +/- ##
===========================================
+ Coverage 63.92% 64.06% +0.14%
===========================================
Files 242 242
Lines 20001 19996 -5
===========================================
+ Hits 12785 12811 +26
+ Misses 6165 6147 -18
+ Partials 1051 1038 -13
|
ebuchman
reviewed
Jun 24, 2019
docs/introduction/install.md
Outdated
| tendermint node --proxy_app=kvstore | ||
| ``` | ||
|
|
||
| _DISCLAIMER_ The binary of tendermint is build/installed without the DWARF symbol table. If you would like to build/install tendermint with the DWARF symbol and debug information, remove `-s -w` from `BUILD_FLAGS` in the make file. |
Contributor
There was a problem hiding this comment.
Should probably be under Install section?
Contributor
Author
There was a problem hiding this comment.
moved it up to ### Compile section
ebuchman
approved these changes
Jun 24, 2019
unclezoro
pushed a commit
to unclezoro/tendermint
that referenced
this pull request
Sep 6, 2019
* Added a disaclaimer so the user is aware of binary - added disclaimer for `-s -w` Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * move up to compile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-s -wSigned-off-by: Marko Baricevic marbar3778@yahoo.com