Remove double lint#3748
Merged
ebuchman merged 1 commit intotendermint:developfrom Jun 24, 2019
tac0turtle:marko/remove_double-lint
Merged
Remove double lint#3748ebuchman merged 1 commit intotendermint:developfrom tac0turtle:marko/remove_double-lint
ebuchman merged 1 commit intotendermint:developfrom
tac0turtle:marko/remove_double-lint
Conversation
- Circel CI and Golangci were doing linting jobs, removed circleci Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## develop #3748 +/- ##
==========================================
+ Coverage 63.97% 64.2% +0.22%
==========================================
Files 242 242
Lines 20010 20010
==========================================
+ Hits 12801 12847 +46
+ Misses 6166 6125 -41
+ Partials 1043 1038 -5
|
|
I tried to update this check manually, but it doesn't look like CircleCI is using the github checks api (possibly because it's still under active development) To merge this you'll need a repo admin to disable the check from the branch protection rules: https://circleci.com/docs/2.0/enable-checks/#github-checks-waiting-for-status-in-github |
unclezoro
pushed a commit
to unclezoro/tendermint
that referenced
this pull request
Sep 6, 2019
- Circel CI and Golangci were doing linting jobs, removed circleci Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cannot be merged until it is removed from circleci.
@mircea-c can you remove it from circleci?
Signed-off-by: Marko Baricevic marbar3778@yahoo.com