update docs/app-dev/abci-cli.md#3747
Merged
melekes merged 2 commits intotendermint:developfrom Jun 25, 2019
Angelo-zz:update_docs
Merged
update docs/app-dev/abci-cli.md#3747melekes merged 2 commits intotendermint:developfrom Angelo-zz:update_docs
melekes merged 2 commits intotendermint:developfrom
Angelo-zz:update_docs
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3747 +/- ##
===========================================
+ Coverage 63.97% 64.09% +0.11%
===========================================
Files 242 213 -29
Lines 20010 17381 -2629
===========================================
- Hits 12801 11140 -1661
+ Misses 6166 5311 -855
+ Partials 1043 930 -113
|
melekes
approved these changes
Jun 24, 2019
Contributor
melekes
left a comment
There was a problem hiding this comment.
🍃 🌴 🌤
Thanks for contributing to Tendermint 👍
docs/app-dev/abci-cli.md
Outdated
| example directory](https://github.com/tendermint/tendermint/tree/develop/abci/example). | ||
|
|
||
| To run the Node JS version, `cd` to `example/js` and run | ||
| To run the Node JS version, You'll also need to fetch the relevant repository, from [here](https://github.com/tendermint/js-abci), then install it: |
Contributor
There was a problem hiding this comment.
Suggested change
| To run the Node JS version, You'll also need to fetch the relevant repository, from [here](https://github.com/tendermint/js-abci), then install it: | |
| To run the Node.js version, fist download & install [the Javascript ABCI server](https://github.com/tendermint/js-abci): |
melekes
reviewed
Jun 24, 2019
docs/app-dev/abci-cli.md
Outdated
| npm install abci | ||
| ``` | ||
|
|
||
| Now run the app: |
Contributor
There was a problem hiding this comment.
Suggested change
| Now run the app: | |
| Now you can start the app: |
Contributor
|
Can you update the settings in your fork to allow us to commit directly so we can apply the suggested changes? Thanks! |
Author
|
I have updated the changes of my fork. |
melekes
approved these changes
Jun 25, 2019
unclezoro
pushed a commit
to unclezoro/tendermint
that referenced
this pull request
Sep 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.