Make RPC bind to localhost by default#3746
Conversation
|
Changing the default RPC binding address to
The relevant CircleCI tests have been modified now to cater for this change. |
Codecov Report
@@ Coverage Diff @@
## develop #3746 +/- ##
===========================================
- Coverage 63.97% 63.95% -0.03%
===========================================
Files 242 242
Lines 20010 19931 -79
===========================================
- Hits 12801 12746 -55
+ Misses 6166 6150 -16
+ Partials 1043 1035 -8
|
|
We can also move tendermint/cmd/tendermint/commands/testnet.go Lines 195 to 196 in 3e7752c |
|
|
||
| COPY wrapper.sh /usr/bin/wrapper.sh | ||
|
|
||
| COPY config-template.toml /etc/tendermint/config-template.toml |
There was a problem hiding this comment.
I added this here but to no effect (see the CircleCI build logs).
Upon investigation, it appears as though the localnet test pulls the localnode Docker image, which was last updated 6 months ago.
@greg-szabo: Is there somewhere where localnode gets built/pushed automatically? Or is it a manual process?
I'm going to make it a prerequisite for localnet-start to build localnode locally for now and see if that helps the build process.
There was a problem hiding this comment.
Seems like it did help the build process 😁
* Make RPC bind to localhost by default * Add CHANGELOG_PENDING entry * Allow testnet command to override RPC listen address * Update localnet test to bind RPC to 0.0.0.0 * Update p2p test to bind RPC to 0.0.0.0 * Remove rpc-laddr parameter * Update localnet to use config template with RPC listen address override * Use config template override method for RPC listen address * Build config template into localnode image * Build localnode image locally before starting localnet * Move testnet config overrides into templates * Revert deletion of config overrides * Remove extraneous config parameter overrides
Addresses #3724