Skip to content

node: run whole func in goroutine, not just logger.Error fn#3743

Merged
melekes merged 2 commits intodevelopfrom
3741-halt
Jun 22, 2019
Merged

node: run whole func in goroutine, not just logger.Error fn#3743
melekes merged 2 commits intodevelopfrom
3741-halt

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Jun 21, 2019

Fixes #3741
Introduced in: 7b162f5

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@melekes melekes requested review from ebuchman and xla as code owners June 21, 2019 14:18
@melekes melekes self-assigned this Jun 21, 2019
@codecov-io
Copy link

codecov-io commented Jun 21, 2019

Codecov Report

Merging #3743 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3743      +/-   ##
===========================================
- Coverage    63.95%   63.94%   -0.01%     
===========================================
  Files          241      241              
  Lines        19996    19994       -2     
===========================================
- Hits         12788    12785       -3     
- Misses        6162     6163       +1     
  Partials      1046     1046
Impacted Files Coverage Δ
node/node.go 62.73% <0%> (-0.22%) ⬇️
rpc/grpc/client_server.go 71.42% <0%> (-10.39%) ⬇️
privval/signer_remote.go 80% <0%> (-2%) ⬇️
consensus/reactor.go 72.11% <0%> (-0.95%) ⬇️
consensus/state.go 79.73% <0%> (-0.24%) ⬇️
consensus/replay.go 71.02% <0%> (+0.81%) ⬆️
blockchain/reactor.go 74.29% <0%> (+0.93%) ⬆️
blockchain/pool.go 82.56% <0%> (+0.98%) ⬆️
p2p/pex/pex_reactor.go 83.23% <0%> (+1.17%) ⬆️
types/tx.go 91.3% <0%> (+4.34%) ⬆️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestedACK

@melekes melekes merged commit 8fc8368 into develop Jun 22, 2019
@melekes melekes deleted the 3741-halt branch June 22, 2019 06:30
unclezoro pushed a commit to unclezoro/tendermint that referenced this pull request Sep 6, 2019
…nt#3743)

* node: run whole func in goroutine, not just logger.Error fn

Fixes tendermint#3741

* add a changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants