Changes to files that had linting issue#3731
Merged
melekes merged 1 commit intotendermint:developfrom Jun 21, 2019
tac0turtle:marko/linting-cleanup
Merged
Changes to files that had linting issue#3731melekes merged 1 commit intotendermint:developfrom tac0turtle:marko/linting-cleanup
melekes merged 1 commit intotendermint:developfrom
tac0turtle:marko/linting-cleanup
Conversation
- Govet issues fixed - 1 gosec issue solved using nolint Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## develop #3731 +/- ##
==========================================
+ Coverage 63.87% 63.9% +0.02%
==========================================
Files 241 241
Lines 19985 19978 -7
==========================================
+ Hits 12766 12767 +1
+ Misses 6171 6166 -5
+ Partials 1048 1045 -3
|
melekes
reviewed
Jun 19, 2019
|
|
||
| func getServiceURL(rootURL string) (url, urnDomain string, err error) { | ||
| r, err := http.Get(rootURL) | ||
| r, err := http.Get(rootURL) // nolint: gosec |
Contributor
There was a problem hiding this comment.
is this something we should worry about?
Contributor
Author
There was a problem hiding this comment.
the lint error arises because rootURL is a variable, but this is the assumption being made with the parameter of getServiceURL being rootURL
Contributor
There was a problem hiding this comment.
Can this be exploited? Probably yes, but I guess validators who's using upnp know about this.
Contributor
Author
There was a problem hiding this comment.
I don't believe it can be exploited, it is only used in one place in the code space and that is to get the serviceURL and urnDomain for NAT. I'm not in tune with possible exploits of this, but I may be wrong.
unclezoro
pushed a commit
to unclezoro/tendermint
that referenced
this pull request
Sep 6, 2019
- Govet issues fixed - 1 gosec issue solved using nolint Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3262
Signed-off-by: Marko Baricevic marbar3778@yahoo.com