Skip to content

Prepare nuking develop#3726

Merged
ebuchman merged 7 commits intodevelopfrom
ismail/nuke_develop_prep
Jun 21, 2019
Merged

Prepare nuking develop#3726
ebuchman merged 7 commits intodevelopfrom
ismail/nuke_develop_prep

Conversation

@liamsi
Copy link
Contributor

@liamsi liamsi commented Jun 16, 2019

Signed-off-by: Ismail Khoffi Ismail.Khoffi@gmail.com

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@liamsi
Update Readme and contrib. guidelines: remove traces of master
ea51e98 
Signed-off-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
@liamsi liamsi requested review from ebuchman, melekes and xla as code owners June 16, 2019 10:27
@liamsi
add simple example
a37dc4a 
Signed-off-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
@codecov-io
Copy link

codecov-io commented Jun 16, 2019 •
edited
Loading

Codecov Report

Merging #3726 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3726      +/-   ##
===========================================
- Coverage    63.93%   63.82%   -0.11%     
===========================================
  Files          241      241              
  Lines        19856    19972     +116     
===========================================
+ Hits         12694    12748      +54     
- Misses        6125     6176      +51     
- Partials      1037     1048      +11
Impacted Files Coverage Δ
privval/signer_validator_endpoint.go 75.55% <0%> (-10%) ⬇️
privval/socket_listeners.go 86.2% <0%> (-3.45%) ⬇️
mempool/clist_mempool.go 81.54% <0%> (-2.17%) ⬇️
privval/signer_remote.go 80% <0%> (-2%) ⬇️
blockchain/reactor.go 71.49% <0%> (-1.87%) ⬇️
blockchain/pool.go 80.26% <0%> (-1.65%) ⬇️
libs/db/prefix_db.go 55.62% <0%> (-0.57%) ⬇️
consensus/reactor.go 71.47% <0%> (-0.12%) ⬇️
consensus/replay.go 71.02% <0%> (+0.81%) ⬆️
types/proposal.go 91.3% <0%> (+1.56%) ⬆️
... and 1 more

liamsi
liamsi commented Jun 16, 2019
View reviewed changes
liamsi added 2 commits June 16, 2019 12:51
@liamsi
Update CONTRIBUTING.md
ed8bcc4
@liamsi
add a note on master and releases
6c63548 
Signed-off-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
melekes
melekes approved these changes Jun 16, 2019
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This was referenced Jun 17, 2019
Closed
Closed
@ebuchman ebuchman merged commit 59497c3 into develop Jun 21, 2019
@melekes melekes deleted the ismail/nuke_develop_prep branch June 22, 2019 05:06
unclezoro pushed a commit to unclezoro/tendermint that referenced this pull request Sep 6, 2019
@liamsi @unclezoro
Prepare nuking develop (tendermint#3726)
e6cb968 
* Update Readme and contrib. guidelines: remove traces of master

Signed-off-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

* add simple example

Signed-off-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

* update contributing.md

* add link

* Update CONTRIBUTING.md

* add a note on master and releases

Signed-off-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xla xla Awaiting requested review from xla

3 more reviewers

@melekes melekes melekes approved these changes

@ebuchman ebuchman ebuchman approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liamsi @codecov-io @melekes @ebuchman @tac0turtle